Skip to content

refactor(builtins): migrate base64, date, cut to ArgParser#897

Merged
chaliy merged 1 commit intomainfrom
fix/issue-880-argparser-migration
Mar 28, 2026
Merged

refactor(builtins): migrate base64, date, cut to ArgParser#897
chaliy merged 1 commit intomainfrom
fix/issue-880-argparser-migration

Conversation

@chaliy
Copy link
Copy Markdown
Contributor

@chaliy chaliy commented Mar 28, 2026

Summary

Test plan

  • All 1929 existing bashkit tests pass
  • cargo clippy -- -D warnings clean
  • cargo fmt --check clean
  • base64 encode/decode/wrap/roundtrip tests pass
  • date and cut spec_case tests pass

Ref #880

Replace manual `while i < ctx.args.len()` loops with ArgParser in
base64, date, and cut builtins. This is the first batch of the
incremental migration described in #880.

Ref #880
@chaliy chaliy merged commit 1eb29b2 into main Mar 28, 2026
27 checks passed
@chaliy chaliy deleted the fix/issue-880-argparser-migration branch March 28, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant